Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-361: Fix flaky tests related to datetime #1558

Merged
merged 4 commits into from Mar 7, 2022

Conversation

leighdouglas
Copy link
Contributor

📲 What

Added miliseconds to date time in unit tests to fix flakey test.

📋 QA

  • Run MessageTest a few times, ensure it is not failing sometimes

Story 📖

NTV-361: Fix flaky tests related to datetime

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1558 (82afa61) into master (78f909f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1558   +/-   ##
=========================================
  Coverage     76.09%   76.09%           
  Complexity     1507     1507           
=========================================
  Files           355      355           
  Lines         14367    14367           
  Branches       1604     1604           
=========================================
  Hits          10932    10932           
  Misses         2592     2592           
  Partials        843      843           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f909f...82afa61. Read the comment docs.

@leighdouglas leighdouglas merged commit 0836370 into master Mar 7, 2022
@leighdouglas leighdouglas deleted the leigh/ntv-361-flaky-datetime branch March 7, 2022 16:09
Arkariang added a commit that referenced this pull request Mar 7, 2022
…tin/NTV-423-bug-fixing

* 'master' of github.com:kickstarter/android-oss:
  NTV-361: Fix flaky tests related to datetime (#1558)
  Update comment counts to include replies (#1555)
@leighdouglas leighdouglas changed the title NTV-361: Fix flaky tests related to datetime WEB-361: Fix flaky tests related to datetime Mar 8, 2022
Arkariang added a commit that referenced this pull request Mar 10, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss:
  NTV-410 && NTV-406: Bug fixing. (#1562)
  NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559)
  WEB-361: Fix flaky date time test in RefTagUtils (#1561)
  NTV-423: bug fixing on Campaign tabg (#1560)
  NTV-361: Fix flaky tests related to datetime (#1558)
  Update comment counts to include replies (#1555)
  - revert back gradle version
  Migrate update.java to kotlin and deprecate AutoParcel (#1553)
  NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554)
  NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551)
  NTV-415 :Jacoco code coverage only looking throw Java classes (#1550)
  NTV-399  Reply comments created with invalid commentable (#1549)
  NTV-414: /v1/activities was called from the app several times #1548
  NTV-412: Hide old campaign links #1547
Arkariang added a commit that referenced this pull request Mar 18, 2022
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore

* 'master' of github.com:kickstarter/android-oss:
  NTV-385: Migrate to kotlin and deprecate autoparcel ProjectNotification model (#1567)
  NTV-429: Gifs on last row on campaign tab not loading on first try (#1566)
  NTV-384 : Migrate MessageThread.java to kotlin and deprecate Autoparcel (#1565)
  NTV-386: Migrate SurveyResponse.java to kotlin and deprecate Autoparcel (#1564)
  NTV-422 DeepLinks bug while QA (#1563)
  NTV-410 && NTV-406: Bug fixing. (#1562)
  NTV-382: Migrate Activity.java to kotlin, deprecate autoparcel (#1559)
  WEB-361: Fix flaky date time test in RefTagUtils (#1561)
  NTV-423: bug fixing on Campaign tabg (#1560)
  NTV-361: Fix flaky tests related to datetime (#1558)
  Update comment counts to include replies (#1555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants