Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-1571: Rewards Carousel can display localReceiptLocation UI #1614

Merged
merged 3 commits into from Apr 27, 2022

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Apr 27, 2022

📲 What

A new type of shipping preference has been added. Now a reward can be collected locally

🛠 How

  • The reward model has been extended with a new optional Location field named localReceiptLocation
  • A New shippingPreference type has been added LOCAL

👀 See

https://user-images.githubusercontent.com/4083656/165413650-55a43750-8453-472e-a78f-e1eedfddee79.mp4
Screen Shot 2022-04-26 at 5 19 45 PM

| | |

📋 QA

Story 📖

PAY-1571

@Arkariang Arkariang requested review from hadia and leighdouglas and removed request for hadia April 27, 2022 00:23
@Arkariang Arkariang marked this pull request as ready for review April 27, 2022 00:23
@Arkariang Arkariang requested a review from hadia April 27, 2022 00:25
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1614 (7c2fd3d) into master (23e8eef) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #1614      +/-   ##
============================================
- Coverage     77.98%   77.98%   -0.01%     
- Complexity     1779     1787       +8     
============================================
  Files           356      356              
  Lines         15929    15951      +22     
  Branches       1841     1846       +5     
============================================
+ Hits          12422    12439      +17     
- Misses         2518     2521       +3     
- Partials        989      991       +2     
Impacted Files Coverage Δ
...arter/services/transformers/GraphQLTransformers.kt 6.87% <0.00%> (-0.05%) ⬇️
...ain/java/com/kickstarter/libs/utils/RewardUtils.kt 70.68% <60.00%> (+0.31%) ⬆️
app/src/main/java/com/kickstarter/models/Reward.kt 82.60% <84.61%> (+0.22%) ⬆️
...va/com/kickstarter/mock/factories/RewardFactory.kt 100.00% <100.00%> (ø)
...src/main/java/com/kickstarter/models/StoredCard.kt 94.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e8eef...7c2fd3d. Read the comment docs.

@Arkariang Arkariang merged commit 69b3fc8 into master Apr 27, 2022
@Arkariang Arkariang deleted the imartin/PAY-1445 branch April 27, 2022 16:22
Arkariang added a commit that referenced this pull request May 30, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (41 commits)
  [No-jira]: remove autoparcel dependencies (#1628)
  Update internal and external version coddes after release
  NTV-542: Update Exoplayer dependency to 2.17.1 (#1627)
  WEB-476 :open editorial Link to deep link android app not working (#1587)
  NTV-380  :Migrate Environment.java to kotlin and deprecate Autoparcel (#1626)
  NTV-483: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1625)
  NTV-537: Update perimeterX (#1624)
  PAY-1587: Translations (#1623)
  NTV-480: Migrate InternalBuildEnvelope.java to kotlin and deprecate Autoparcel (#1612)
  NTV-483 :Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1622)
  PAY-1445: Add ons local receipt UI (#1621)
  NTV-535: Fix crashes (#1620)
  PAY-1441: Add ons for local pickup reward (#1619)
  NTV-479  :Migrate Activity.java Push model to kotlin and deprecate Autoparcel (#1618)
  PAY-1521: Pledge Screen show localReceiptLocation UI (#1617)
  NTV-486: Migrate StarEnvelope.java to kotlin and deprecate Autoparcel (#1615)
  [No-jira]: Update schema.json (#1616)
  PAY-1571: Rewards Carousel can display localReceiptLocation UI (#1614)
  PAY-1524: Added new feature flag + updated Schema.json (#1613)
  NTV-493: Deprecate Autoparcel for PledgeData.kt (#1611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants