Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-1587: Translations #1623

Merged
merged 2 commits into from May 9, 2022
Merged

PAY-1587: Translations #1623

merged 2 commits into from May 9, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Translations

- ANR related to DiscoveryParams
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Arkariang Arkariang changed the title PSY-1587: Translations PAY-1587: Translations May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1623 (2830ef8) into master (cd5d8a8) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #1623      +/-   ##
============================================
- Coverage     78.66%   78.65%   -0.01%     
- Complexity     1831     1832       +1     
============================================
  Files           354      354              
  Lines         16088    16088              
  Branches       1875     1877       +2     
============================================
- Hits          12655    12654       -1     
  Misses         2419     2419              
- Partials       1014     1015       +1     
Impacted Files Coverage Δ
.../com/kickstarter/libs/utils/AnalyticEventsUtils.kt 73.19% <50.00%> (-0.52%) ⬇️
...src/main/java/com/kickstarter/models/StoredCard.kt 94.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5d8a8...2830ef8. Read the comment docs.

@Arkariang Arkariang merged commit 77360c1 into master May 9, 2022
@Arkariang Arkariang deleted the imartin/PAY-1587-translations branch May 9, 2022 17:07
Arkariang added a commit that referenced this pull request May 30, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (41 commits)
  [No-jira]: remove autoparcel dependencies (#1628)
  Update internal and external version coddes after release
  NTV-542: Update Exoplayer dependency to 2.17.1 (#1627)
  WEB-476 :open editorial Link to deep link android app not working (#1587)
  NTV-380  :Migrate Environment.java to kotlin and deprecate Autoparcel (#1626)
  NTV-483: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1625)
  NTV-537: Update perimeterX (#1624)
  PAY-1587: Translations (#1623)
  NTV-480: Migrate InternalBuildEnvelope.java to kotlin and deprecate Autoparcel (#1612)
  NTV-483 :Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1622)
  PAY-1445: Add ons local receipt UI (#1621)
  NTV-535: Fix crashes (#1620)
  PAY-1441: Add ons for local pickup reward (#1619)
  NTV-479  :Migrate Activity.java Push model to kotlin and deprecate Autoparcel (#1618)
  PAY-1521: Pledge Screen show localReceiptLocation UI (#1617)
  NTV-486: Migrate StarEnvelope.java to kotlin and deprecate Autoparcel (#1615)
  [No-jira]: Update schema.json (#1616)
  PAY-1571: Rewards Carousel can display localReceiptLocation UI (#1614)
  PAY-1524: Added new feature flag + updated Schema.json (#1613)
  NTV-493: Deprecate Autoparcel for PledgeData.kt (#1611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants