New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No-jira]: remove autoparcel dependencies #1628
Conversation
@@ -206,9 +206,6 @@ dependencies { | |||
implementation 'com.facebook.android:facebook-android-sdk:12.0.1' | |||
implementation 'com.google.android.play:core-ktx:1.8.1' | |||
implementation 'androidx.constraintlayout:constraintlayout:2.1.3' | |||
final auto_parcel_version = "0.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💖 🔥 👍
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
============================================
+ Coverage 78.35% 78.38% +0.03%
+ Complexity 1865 1862 -3
============================================
Files 354 353 -1
Lines 16520 16509 -11
Branches 2033 2032 -1
============================================
- Hits 12944 12941 -3
+ Misses 2419 2412 -7
+ Partials 1157 1156 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
…e/NTV-411-integrate-payment-sheet * 'master' of github.com:kickstarter/android-oss: (41 commits) [No-jira]: remove autoparcel dependencies (#1628) Update internal and external version coddes after release NTV-542: Update Exoplayer dependency to 2.17.1 (#1627) WEB-476 :open editorial Link to deep link android app not working (#1587) NTV-380 :Migrate Environment.java to kotlin and deprecate Autoparcel (#1626) NTV-483: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1625) NTV-537: Update perimeterX (#1624) PAY-1587: Translations (#1623) NTV-480: Migrate InternalBuildEnvelope.java to kotlin and deprecate Autoparcel (#1612) NTV-483 :Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1622) PAY-1445: Add ons local receipt UI (#1621) NTV-535: Fix crashes (#1620) PAY-1441: Add ons for local pickup reward (#1619) NTV-479 :Migrate Activity.java Push model to kotlin and deprecate Autoparcel (#1618) PAY-1521: Pledge Screen show localReceiptLocation UI (#1617) NTV-486: Migrate StarEnvelope.java to kotlin and deprecate Autoparcel (#1615) [No-jira]: Update schema.json (#1616) PAY-1571: Rewards Carousel can display localReceiptLocation UI (#1614) PAY-1524: Added new feature flag + updated Schema.json (#1613) NTV-493: Deprecate Autoparcel for PledgeData.kt (#1611) ...
📲 What
remove
auto_parcel_version
dependicice