Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-380 :Migrate Environment.java to kotlin and deprecate Autoparcel #1626

Merged
merged 13 commits into from May 19, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented May 12, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

📋 QA

Test Who App for Environment object used for local, user object ,sharedpreference

Story 📖

https://kickstarter.atlassian.net/browse/NTV-380

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1626 (b83c983) into master (fe584cc) will decrease coverage by 0.30%.
The diff coverage is 65.60%.

@@             Coverage Diff              @@
##             master    #1626      +/-   ##
============================================
- Coverage     78.65%   78.35%   -0.31%     
- Complexity     1841     1865      +24     
============================================
  Files           354      354              
  Lines         16370    16520     +150     
  Branches       1949     2033      +84     
============================================
+ Hits          12876    12944      +68     
  Misses         2419     2419              
- Partials       1075     1157      +82     
Impacted Files Coverage Δ
...ava/com/kickstarter/viewmodels/AccountViewModel.kt 83.07% <0.00%> (-1.54%) ⬇️
...kickstarter/viewmodels/CampaignDetailsViewModel.kt 91.11% <0.00%> (-8.89%) ⬇️
...om/kickstarter/viewmodels/CancelPledgeViewModel.kt 97.22% <0.00%> (-2.78%) ⬇️
...com/kickstarter/viewmodels/ChangeEmailViewModel.kt 91.81% <0.00%> (-0.91%) ⬇️
...va/com/kickstarter/viewmodels/CommentsViewModel.kt 86.60% <0.00%> (-0.57%) ⬇️
.../kickstarter/viewmodels/CreatePasswordViewModel.kt 92.06% <0.00%> (-4.77%) ⬇️
.../com/kickstarter/viewmodels/CreatorBioViewModel.kt 92.50% <0.00%> (-2.50%) ⬇️
...iewmodels/CreatorDashboardHeaderHolderViewModel.kt 97.33% <0.00%> (-1.36%) ⬇️
...va/com/kickstarter/viewmodels/DeepLinkViewModel.kt 93.33% <0.00%> (-2.25%) ⬇️
...a/com/kickstarter/viewmodels/DiscoveryViewModel.kt 93.80% <0.00%> (-2.50%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe584cc...b83c983. Read the comment docs.

@hadia hadia added the migration Migration Java to Kotlin label May 16, 2022
@hadia hadia marked this pull request as ready for review May 16, 2022 16:45
@hadia hadia changed the title Ntv 380 migrate environment.java to kotlin NTV-380 :Migrate Environment.java to kotlin and deprecate Autoparcel May 16, 2022
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀🚀

@hadia hadia merged commit b848c62 into master May 19, 2022
@hadia hadia deleted the NTV-380_Migrate_Environment.java_to_kotlin branch May 19, 2022 17:40
Arkariang added a commit that referenced this pull request May 30, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (41 commits)
  [No-jira]: remove autoparcel dependencies (#1628)
  Update internal and external version coddes after release
  NTV-542: Update Exoplayer dependency to 2.17.1 (#1627)
  WEB-476 :open editorial Link to deep link android app not working (#1587)
  NTV-380  :Migrate Environment.java to kotlin and deprecate Autoparcel (#1626)
  NTV-483: Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1625)
  NTV-537: Update perimeterX (#1624)
  PAY-1587: Translations (#1623)
  NTV-480: Migrate InternalBuildEnvelope.java to kotlin and deprecate Autoparcel (#1612)
  NTV-483 :Migrate ProjectStatsEnvelope.java to kotlin and deprecate Autoparcel (#1622)
  PAY-1445: Add ons local receipt UI (#1621)
  NTV-535: Fix crashes (#1620)
  PAY-1441: Add ons for local pickup reward (#1619)
  NTV-479  :Migrate Activity.java Push model to kotlin and deprecate Autoparcel (#1618)
  PAY-1521: Pledge Screen show localReceiptLocation UI (#1617)
  NTV-486: Migrate StarEnvelope.java to kotlin and deprecate Autoparcel (#1615)
  [No-jira]: Update schema.json (#1616)
  PAY-1571: Rewards Carousel can display localReceiptLocation UI (#1614)
  PAY-1524: Added new feature flag + updated Schema.json (#1613)
  NTV-493: Deprecate Autoparcel for PledgeData.kt (#1611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants