Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1318: Removed Picasso dependency #2018

Merged
merged 3 commits into from
Apr 16, 2024
Merged

MBL-1318: Removed Picasso dependency #2018

merged 3 commits into from
Apr 16, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Apr 16, 2024

📲 What

  • Removed last instance of Picasso
  • Removed dependency
  • Updated Glide version

🤔 Why

👀 See

On notifications, some icons are circle shaped, some are squared with rounded corners. Compare previous build version with this one:
Screenshot 2024-04-15 at 5 09 05 PM
Screenshot 2024-04-15 at 5 08 51 PM

Notifications.mp4

| | |

📋 QA

  • Browser around the app, see images working as before
  • Go to internal tools, push notifications -> trigger notification for "Friend following" (circle icon), trigger notification for "Project success" square with round corners shape

Story 📖

MBL-1318

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.23%. Comparing base (f82a05f) to head (0122a5c).

Files Patch % Lines
...n/java/com/kickstarter/libs/PushNotifications.java 0.00% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2018      +/-   ##
============================================
+ Coverage     67.16%   67.23%   +0.06%     
  Complexity     2057     2057              
============================================
  Files           355      353       -2     
  Lines         21483    21463      -20     
  Branches       3029     3026       -3     
============================================
  Hits          14430    14430              
+ Misses         5445     5425      -20     
  Partials       1608     1608              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ycheng-kickstarter ycheng-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkariang Arkariang merged commit 4bb904f into master Apr 16, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1318 branch April 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants