Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1383] Update adding new payment method flow in late pledge flow #2026

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Apr 25, 2024

📲 What

Change it so that instead of creating a payment intent and then using that to set up a card via stripe (which would charge immediately) we are using a setupintent and saving the card to backend, similar to what we do in the account card screen. We then refresh the users stored cards so they show on the list.

🤔 Why

When doing the payment intent way it would charge cards immediately, causing double charges via stripe

🛠 How

Changed the code to save the new cards instead of have a temporary copy via payment intent

📋 QA

  1. Go to a project that is accepting late pledges ("testing conversion" on staging)
  2. Proceed to the checkout screen
  3. add a new card
  4. proceed with checkout with the new card
  5. Confirm card was only charged once (this may require backend help)

Story 📖

MBL-1383

@mtgriego mtgriego self-assigned this Apr 25, 2024
@mtgriego mtgriego added bug 🐛 release 🚀 Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 labels Apr 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 67.30%. Comparing base (86b7ec3) to head (eebf2c5).

Files Patch % Lines
...wmodels/projectpage/LatePledgeCheckoutViewModel.kt 0.00% 24 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2026      +/-   ##
============================================
+ Coverage     67.28%   67.30%   +0.01%     
+ Complexity     2062     2061       -1     
============================================
  Files           353      353              
  Lines         21466    21459       -7     
  Branches       3028     3026       -2     
============================================
- Hits          14444    14443       -1     
+ Misses         5413     5406       -7     
- Partials       1609     1610       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and reviewed with bessie only one charged for my created payment intent

@mtgriego mtgriego marked this pull request as ready for review April 25, 2024 22:00
@mtgriego mtgriego merged commit a063f8d into master Apr 29, 2024
3 checks passed
@mtgriego mtgriego deleted the adding-payment-method-fix branch April 29, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 release 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants