[NT-648] Login/Signup Event Cleanup #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
justinswart
approved these changes
Jan 8, 2020
| @@ -255,6 +255,7 @@ final class PledgeViewController: UIViewController, MessageBannerViewControllerP | |||
| self.viewModel.outputs.configureWithData | |||
| .observeForUI() | |||
| .observeValues { [weak self] data in | |||
| self?.continueViewController.configureWith(value: data) | |||
There was a problem hiding this comment.
Note to self that we should consider combining the continue button VC with our submit button 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updates events for the login/signup flow.
🤔 Why
Event cleanup.
🛠 How
Renaming some events, deleting others.
✅ Acceptance criteria
Test the following events:
Log In or Signup Button Clicked// when the entry point button for login/signup is clickedLog In or Sign Up Page Viewed// when the login/signup page is viewedFacebook Log In or Signup Button Clicked//when the facebook button is clickedLog In Button Clicked//when the "Log in" button is clicked from the login/out screenSign Up Button Clicked// when the "Sign up" button is clicked from the login/out screenLog In Submit Button Clicked// when the Login button is clicked from the login screenSign Up Submit Button Clicked// when the Signup button is clicked from the sign up screen