[NT-647] "Thanks Page Viewed" event #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NT-647-thank-you-event # Conflicts: # Library/Tracking/Koala.swift
Generated by 🚫 Danger |
Scollaco
reviewed
Jan 15, 2020
|
|
||
| self.scheduler.run() | ||
|
|
||
| self.goToThanks.assertValues([project]) | ||
| self.goToThanksProject.assertValues([project]) |
There was a problem hiding this comment.
Should we assert the values of goToThanksReward and goToThanksCheckoutData here too? 🤔
| self.showErrorBannerWithMessage.assertDidNotEmitValue() | ||
|
|
||
| self.scheduler.run() | ||
|
|
||
| self.beginSCAFlowWithClientSecret.assertDidNotEmitValue() | ||
| self.submitButtonEnabled.assertValues([false, true, false, true]) | ||
| self.submitButtonIsLoading.assertValues([true, false]) | ||
| self.goToThanks.assertValues([.template]) | ||
| self.goToThanksProject.assertValues([.template]) |
| @@ -3095,7 +3114,7 @@ final class PledgeViewModelTests: TestCase { | |||
|
|
|||
| self.beginSCAFlowWithClientSecret.assertValues(["client-secret"]) | |||
| self.submitButtonEnabled.assertValues([false, true, false, true]) | |||
| self.goToThanks.assertValues([project]) | |||
| self.goToThanksProject.assertValues([project]) | |||
| fileprivate let goToThanks = TestObserver<Project, Never>() | ||
| fileprivate let goToThanksProject = TestObserver<Project, Never>() | ||
| fileprivate let goToThanksReward = TestObserver<Reward, Never>() | ||
| fileprivate let goToThanksCheckoutData = TestObserver<Koala.CheckoutPropertiesData?, Never>() |
| fileprivate let goToThanks = TestObserver<Project, Never>() | ||
| fileprivate let goToThanksProject = TestObserver<Project, Never>() | ||
| fileprivate let goToThanksReward = TestObserver<Reward, Never>() | ||
| fileprivate let goToThanksCheckoutData = TestObserver<Koala.CheckoutPropertiesData?, Never>() |
| private let goToThanks = TestObserver<Project, Never>() | ||
| private let goToThanksProject = TestObserver<Project, Never>() | ||
| private let goToThanksReward = TestObserver<Reward, Never>() | ||
| private let goToThanksCheckoutData = TestObserver<Koala.CheckoutPropertiesData?, Never>() |
Scollaco
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adds the
Thanks Page Viewedevent.🤔 Why
Tracking events cleanup.
🛠 How
Adds the
Thanks Page Viewedevent which includesprojectProperties,pledgePropertiesandcheckoutProperties. Because the checkout properties are mostly defined inPledgeViewModel, they're passed through to theThanksViewModelvia the configuration function.✅ Acceptance criteria
With the
KOALA_ENABLEDenvironment variable set totrue, test the event by backing any project. You should see theThanks Page Viewedevent fire when you get to the thanks page, with the following properties:checkout_amount// pledge total including shippingcheckout_payment_type// eitherCREDIT_CARDorAPPLE_PAYcheckout_reward_idcheckout_reward_titlecheckout_shipping_amountcheckout_revenue_in_usd_centscheckout_reward_estimated_delivery_oncheckout_reward_shipping_enabledcheckout_user_has_eligible_stored_apple_pay_cardas well as all
projectPropertiesandpledgeProperties.Note that you'll only see
checkoutPropertieswhen backing a project through the native pledge view experience, although theThanks Page Viewedevent will also fire through the deprecated checkout experience.