Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-736] Debug tools deviceIdentifier and appVersion #1049

Merged
merged 6 commits into from
Jan 28, 2020

Conversation

Scollaco
Copy link
Contributor

📲 What

  • Adds device's identifierForVendor and appVersion to the footer of BetaToolsViewController.

🤔 Why

From the JIRA ticket:

In order to whitelist our own devices for testing, we'll need to know our own deviceIdentifiers. Displaying the deviceIdentifier on the debug menu will make it easier to test whitelisting our devices into various experimental variants.

Additionally, displaying the App Version on the debug tools menu means that you no longer need to be logged in to see what app version you're on during testing.

🛠 How

  • Extracted the existing footerView to a separated class.
  • Added 2 extra stackViews containing the identifier and app version (The values come from AppEnvironment)
  • To keep the betaFeedback button working, a BetaToolsFooterViewDelegate was created.
  • New snapshots

👀 See

Before 🐛 After 🦋
reference_testBetaToolsViewController@2x debug-tools

✅ Acceptance criteria

  • Open the debug tools menu. The deviceIdentifier and appVersion info should be visible below the beta feedback button
  • The Submit Feedback For Beta button should work normally.

Copy link
Contributor

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 yay!

@Scollaco Scollaco merged commit f492f40 into master Jan 28, 2020
@Scollaco Scollaco deleted the NT-736_debug-tools-identifier-app-version branch January 28, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants