[NT-1011] Upgrade Facebook SDK #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
force-pushed
the
NT-1011-upgrade-fb-sdk
branch
from
9d2e6e0
to
223e031
Compare
jgsamudio
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Upgrades the Facebook SDK to v6.2.0, which fixes an iOS 13 bug where users were unable to log in or sign up using Facebook.
🤔 Why
Users need to be able to log in/signup using Facebook.
🛠 How
6.2.0as thefacebook/facebook-objc-sdkversion, and then rancarthage update facebook-objc-sdkloginBehaviourin the FacebookloginManagersince they deprecated that configuration:👀 See
✅ Acceptance criteria