[NT-1257] Sign In With Apple Killswitch Feature Flag #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adds an
ios_sign_in_with_applefeature flag that acts as a killswitch (hides the button if enabled).🤔 Why
We will soon roll out Sign In With Apple in our next release and we would just like to be able to turn this off if necessary via a feature flag.
🛠 How
ios_sign_in_with_apple_killswitchfeature flag on Optimizely.enabled. If it isdisabledor missing, the button will be shown.👀 See
enabled🟢disabled🔴✅ Acceptance criteria
ios_sign_in_with_apple_killswitchfeature flag. Observe that upon re-launching the app, the Continue with Apple button is hidden.ios_sign_in_with_apple_killswitchfeature flag. Observe that upon re-launching the app, the Continue with Apple button is visible.