MBL-1371: Only show 'Coming Soon' if project is actually pre-launch #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that |
amy-at-kickstarter
force-pushed
the
bug/adyer/mbl-1371/fix-backer-dashboard-status
branch
from
954f7d9
to
2cbabd3
Compare
amy-at-kickstarter
force-pushed
the
bug/adyer/mbl-1371/fix-backer-dashboard-status
branch
from
2cbabd3
to
cccebec
Compare
| switch (project.displayPrelaunch, project.dates.launchedAt, project.prelaunchActivated) { | ||
| case (.some(true), _, _), | ||
| (_, _, .some(true)): | ||
| switch (project.displayPrelaunch, project.prelaunchActivated, project.dates.launchedAt) { |
There was a problem hiding this comment.
Reordered these arguments for clarity - the two bools, then the launch time.
|
OK, I did some additional spot checks here - I tested search (and found and fixed a bug). Now the cards here should display the same information as cards on web for search, including for prelaunch projects: I also created my own prelaunch project on staging, just to verify that it looks like I expect: |
amy-at-kickstarter
requested review from
a team and
ifosli
and removed request for
a team
ifosli
approved these changes
Apr 23, 2024
amy-at-kickstarter
deleted the
bug/adyer/mbl-1371/fix-backer-dashboard-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Check both
displayPrelaunchandprelaunchActivatedflags onProjectbefore showing"Coming Soon"in the project status.🤔 Why
When I swapped this page to use GraphQL, it started returning values in
displayPrelaunchandprelaunchActivatedwhich were formerlynil. This caused the status badges to be incorrect.On a little digging, the existing logic to check for prelaunch status didn't make sense:
prelaunchActivatedrefers to whether the prelaunch page is availabledisplayPrelaunchis true if the project has not actually launched yetI surmised that checking for both, not either, is the correct behavior.
I kept the behavior that checks the launch date - turns out that is used for detecting prelaunch projects fetched via
/v1/discoveri.e. search.👀 See
I checked this by comparing the status badges for my saved projects on prod with the badges in this version. I also created a prelaunch project on staging and verified that it shows "Coming soon" until I actually hit "launch".