Use new Facebook color and glyph #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnywh
commented
Jul 9, 2019
Kickstarter-iOS/Assets.xcassets/icons/fb-logo-white.imageset/Contents.json
Outdated
Show resolved
Hide resolved
dusi
reviewed
Jul 10, 2019
dnywh
changed the title
dnywh
changed the title
added 4 commits
July 18, 2019 14:44
dusi
previously approved these changes
Jul 18, 2019
dnywh
commented
Jul 18, 2019
| ? .init(topBottom: 10.0, leftRight: 12.0) | ||
| : .init(topBottom: 12.0, leftRight: 16.0) | ||
| } | ||
|
|
There was a problem hiding this comment.
@dusi and I realised that we needed to have a custom topBottom for this case. That was causing the visually-squashing problem and why we declare it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🤔 Why
Facebook updated its brand guidelines in April this year.
🛠 How
👀 See
Trello, screenshots, external resources?
⏰ TODO