Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👩‍🔬 [Investment Day] - Consistent pragma mark naming (master) #750

Merged
merged 2 commits into from
Jul 12, 2019
Merged

👩‍🔬 [Investment Day] - Consistent pragma mark naming (master) #750

merged 2 commits into from
Jul 12, 2019

Conversation

dusi
Copy link
Contributor

@dusi dusi commented Jul 12, 2019

📲 What

Renames Binding pragma mark to View model which goes better with our other naming conventions like Styles for bindStyles.

🤔 Why

Consistency, synergy, you name it

✅ Acceptance criteria

  • Passes CI

@dusi dusi merged commit 0e2aa2f into master Jul 12, 2019
@dusi dusi deleted the pragma-mark-consistency-view-model branch July 12, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees

@justinswart justinswart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dusi @justinswart