👩🔬 [Investment Day] - Project detail - modal presentation #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusi
commented
Jul 13, 2019
| @@ -25,9 +25,6 @@ public protocol ProjectPamphletViewModelOutputs { | |||
| /// Emits a project that should be used to configure all children view controllers. | |||
| var configureChildViewControllersWithProject: Signal<(Project, RefTag?), Never> { get } | |||
|
|
|||
| /// Return this value from the view's `prefersStatusBarHidden` method. | |||
| var prefersStatusBarHidden: Bool { get } | |||
dusi
commented
Jul 15, 2019
| @@ -37,11 +37,11 @@ | |||
| </subviews> | |||
| <color key="backgroundColor" white="1" alpha="1" colorSpace="calibratedWhite"/> | |||
| <constraints> | |||
| <constraint firstItem="Bfz-Sg-Kdb" firstAttribute="trailing" secondItem="bdk-Xa-fm9" secondAttribute="trailing" id="3Dg-lk-oRa"/> | |||
| <constraint firstAttribute="trailing" secondItem="bdk-Xa-fm9" secondAttribute="trailing" id="3Dg-lk-oRa"/> | |||
There was a problem hiding this comment.
Changes leading & trailing constraints to align to superview instead of previously safe areas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes the jaggy animation when showing project screen modally.
🤔 Why
Hiding the status bar in landscape mode on iPad causes the modal presentation to cause a weird jump. This happens because we're hiding the status bar in landscape even though it's the default thing on iPhone.
👀 See
Trello, screenshots, external resources?
✅ Acceptance criteria