[Pledge Payment Methods] Replace UICollectionView with UIScrollView #772
Conversation
| let imageViewWidthConstraint = self.imageView.widthAnchor | ||
| .constraint(equalToConstant: Layout.ImageView.width) | ||
| _ = imageViewWidthConstraint | ||
| |> \.priority .~ .defaultHigh |
There was a problem hiding this comment.
None of these priority settings were needed for this approach.
|
|
||
| self.collectionViewHeightConstraint.constant = self.collectionView.contentSize.height | ||
| private func updateScrollViewHeightConstraint() { | ||
| self.scrollViewHeightConstraint.constant = self.scrollView.contentSize.height |
…native-checkout-credit-card-cell-scrollview
There was a problem hiding this comment.
Thank you (so much) for taking a look at this, @justinswart 😄 I left one minor suggestion, but it looks good otherwise.
| @@ -228,12 +228,16 @@ public final class RewardCardView: UIView { | |||
| } | |||
|
|
|||
| private func setupConstraints() { | |||
| let stateImageViewContainerWidthConstraint = self.stateImageViewContainer.widthAnchor | |||
| .constraint(equalToConstant: Styles.grid(5)) | |||
| stateImageViewContainerWidthConstraint.priority = .defaultHigh | |||
There was a problem hiding this comment.
To be consistent with how we've set priority, could you use this instead?
let stateImageViewContainerWidthConstraint = self.stateImageViewContainer.widthAnchor
.constraint(equalToConstant: Styles.grid(5))
|> \.priority .~ .defaultHigh
There was a problem hiding this comment.
😄 i was gonna merge it and make that comment on your PR!
j/k i'll update it.
| self.bindViewModel() | ||
| self.configureSubviews() |
| @@ -228,12 +228,16 @@ public final class RewardCardView: UIView { | |||
| } | |||
|
|
|||
| private func setupConstraints() { | |||
| let stateImageViewContainerWidthConstraint = self.stateImageViewContainer.widthAnchor | |||
There was a problem hiding this comment.
Is this change unrelated?
There was a problem hiding this comment.
It fixes a constraint warning
Sure, I don't think anybody's suggesting this is the ultimate long-term solution, it's more just to get us unstuck on this for now. We can certainly iterate on bringing the collection view back but this allows us to have something that works in the interim. |
justinswart
deleted the
feature-native-checkout-credit-card-cell-scrollview
branch
📲 What
This is my suggested fix for the problematic self-sizing
UICollectionViewthat we've been struggling with in thePledgePaymentMethodsViewController. This is not a view that we expect to show a large amount of cells so I don't think we need to be concerned about view recycling. My suggestion is to replace theUICollectionViewwith aUIScrollView.🤔 Why
We've been fiddling with the self-sizing
UICollectionViewissue for 2 days and I don't think it's worth our time anymore. This works very reliably and has zero constraint warnings, even when resizing with dynamic type.🛠 How
Replace the
UICollectionViewwith aUIScrollView, add the card views to a horizontalUIStackViewand enjoy our lives.👀 See