💲[Native Checkout] Add Shipping Availability Pill #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
approved these changes
Aug 8, 2019
| @@ -194,7 +194,9 @@ private func rewardTitle(project: Project, reward: Reward) -> String { | |||
| private func pillStrings(project: Project, reward: Reward) -> [String] { | |||
| var pillStrings: [String] = [] | |||
|
|
|||
| if let endsAt = reward.endsAt, project.state == .live, endsAt > 0, | |||
There was a problem hiding this comment.
Do we we want to remove the check from the remaining logic too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adds a pill to our
RewardCardViewdescribing the shipping availability of a reward, that is whether it's available anywhere in the world or only in the U.S.🤔 Why
A continuation of the rewards carousel work and necessary information to surface to our international backers.
🛠 How
reward.shipping.summaryand created a pill from that to add to the collection view.👀 See
✅ Acceptance criteria
Note: This does not appear to be localized by the back-end.