-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pledge Screen - Load User's Stored Cards #790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
reviewed
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinswart I've added both of those visual styling comments to our ticket for |
justinswart
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Load a user's stored cards from Graph.
🤔 Why
So users can select a real stored card to pledge with.
🛠 How
This PR does the following:
MessageBanner
if the request failsNote that this PR does not include the loading state for the cards.
👀 See
♿️ Accessibility
N/A
🏎 Performance
N/A
✅ Acceptance criteria
Logged In
Native Checkout Pledge View
feature flag turned ON, navigate to any project and select any reward.PASS In the pledge screen, you should see your user's stored cards load in, with the "Add New Card" tile at the end.
Logged Out
Native Checkout Pledge View
feature flag turned ON, navigate to any project and select any reward. In the pledge screen, you should see theContinue
button. Tap continue and sign in.PASS After you sign in, you should see the sign in overlay dismiss, and your stored cards should load in, with the "Add New Card" tile at the end.
No Network Connectivity
Native Checkout Pledge View
feature flag turned ON, navigate to any project. Turn off your internet (you can do this by turning airplane mode on your device to ON). Then, select any reward.PASS You should not see any cards loaded in. Then, after a few seconds, you should see an error banner appear with the message "Something went wrong".