Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pledge Screen - Load User's Stored Cards #790

Merged
merged 9 commits into from
Aug 12, 2019
Merged

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Aug 9, 2019

📲 What

Load a user's stored cards from Graph.

🤔 Why

So users can select a real stored card to pledge with.

🛠 How

This PR does the following:

  • loads a user's stored cards
  • shows an error MessageBanner if the request fails

Note that this PR does not include the loading state for the cards.

👀 See

Logged In Logged Out
cc0W9qTnzk zspSB8rj0Z

♿️ Accessibility

N/A

🏎 Performance

N/A

✅ Acceptance criteria

Logged In

  • with the Native Checkout Pledge View feature flag turned ON, navigate to any project and select any reward.
    PASS In the pledge screen, you should see your user's stored cards load in, with the "Add New Card" tile at the end.

Logged Out

  • Make sure you are logged out. Then, with the Native Checkout Pledge View feature flag turned ON, navigate to any project and select any reward. In the pledge screen, you should see the Continue button. Tap continue and sign in.
    PASS After you sign in, you should see the sign in overlay dismiss, and your stored cards should load in, with the "Add New Card" tile at the end.

No Network Connectivity

  • Logged in, make sure you have the Native Checkout Pledge View feature flag turned ON, navigate to any project. Turn off your internet (you can do this by turning airplane mode on your device to ON). Then, select any reward.
    PASS You should not see any cards loaded in. Then, after a few seconds, you should see an error banner appear with the message "Something went wrong".

@ifbarrera ifbarrera marked this pull request as ready for review August 9, 2019 18:36
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty cool!

What do you think about making this edge to edge as part of this PR 🤔

I believe it's not meant to clip at these margins:

@justinswart
Copy link
Contributor

Could we remove this type from the xib, seems to complain that it doesn't exist:

image

@justinswart
Copy link
Contributor

Something else either as part of this or separately but we should probably float the card logo to the top:

@ifbarrera
Copy link
Contributor Author

@justinswart I've added both of those visual styling comments to our ticket for iOS Checkout Polish

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit!

@ifbarrera ifbarrera merged commit cf89d65 into master Aug 12, 2019
@ifbarrera ifbarrera deleted the load-user-stored-cards branch August 12, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants