Disabling experiment on debug builds #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Aug 20, 2019
| @@ -37,7 +42,7 @@ final class ExperimentName_HelpersTests: TestCase { | |||
| let config = Config.template | |||
| |> \.abExperiments .~ ["unknown": "experimental"] | |||
|
|
|||
| withEnvironment(config: config) { | |||
| withEnvironment(config: config, mainBundle: self.releaseBundle) { | |||
There was a problem hiding this comment.
Can we add a test to verify that when the bundle is not the .isRelease bundle, that the debugDefault is returned?
ifbarrera
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🤔 Why
The Native Experiment currently makes the Native Checkout unavailable for users that are part of the
controlbucket, making the work and QA for that project impossible.In order to revert this, we should enable experiments exclusively for Release builds, this way the Native Checkout work won't be interrupted.
🛠 How
Following @justinswart 's suggestion, we now have a
debugDefaultvariable inside theExperiment.Nameenum that currently enables both existing experiments.✅ Acceptance criteria
alpha,betaanddebugbuilds, the native checkout show be available regardless the value of the bucket of thenative_checkout_v1experiment. *controlorexperimentalto db/Looker.