Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show backed amount total #810

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Show backed amount total #810

merged 2 commits into from
Aug 21, 2019

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented Aug 20, 2019 •
edited by dusi
Loading

📲 What

  • Displays the full amount of the backing (including shipping).
  • Removes decimals from amount.

🤔 Why

We want to surface this full amount to the backer.

🛠 How

  • Removed code that was manually subtracting the shipping amount.
  • Removed decimal formatting.

Note: We've left the deprecated view as is.

👀 See

Trello, screenshots, external resources?

Before 🐛 After 🦋
image image

✅ Acceptance criteria

  • Navigate to a project that you've backed, you should see the total amount including shipping costs.

@justinswart justinswart requested a review from dusi August 20, 2019 22:48
dusi
dusi approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@dusi dusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢
🚢 🚢 🚢
🚢 🚢 🚢

@justinswart justinswart merged commit 4554b82 into master Aug 21, 2019
@justinswart justinswart deleted the show-backed-amount-total branch August 21, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusi dusi dusi approved these changes

Assignees

@dusi dusi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinswart @dusi @ifbarrera