Fix minor pledge screen issues #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked for now until we release 3.20.0 |
|
Let's actually try to squeeze it in the release (we've already dome some tweaks to |
dusi
added
needs review
and removed
blocked
dusi
commented
Aug 27, 2019
| @@ -352,6 +352,7 @@ internal final class DeprecatedRewardPledgeViewController: UIViewController { | |||
| |> UIScrollView.lens.layoutMargins .~ .init(leftRight: Styles.grid(2)) | |||
| |> UIScrollView.lens.delaysContentTouches .~ false | |||
| |> UIScrollView.lens.keyboardDismissMode .~ .interactive | |||
| |> \.alwaysBounceVertical .~ true | |||
|
For the second ACs of: "The |
cdolm92
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes
🤔 Why
UI improvements
👀 See
Focus on the
Xbutton in the navigation bar (previously we did not dim it which made it look tap-able but since the picker takes over the screen that's not the case - this could be very confusing to the user). The other visual change was done to theCancelandDonebutton, which now look more like buttons, don't support Dynamic Type (for consistency with the rest of the codebase) and are consistent with our styles/colors.✅ Acceptance criteria
Xbutton on the pledge screen dims when shipping location picker is presentedXbutton on the pledge screen reverts back to normal when shipping location picker isdismissed using the
CancelbuttonXbutton on the pledge screen reverts back to normal when shipping location picker is dismissed using theDonebutton