Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat errored pledges as normal #817

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Treat errored pledges as normal #817

merged 3 commits into from
Aug 27, 2019

Conversation

justinswart
Copy link
Contributor

📲 What

Treats errored pledges as normal.

🤔 Why

We're not currently able to handle errored pledges so we need to treat them as normal in the interim to allow the user to at least view their pledge if it has errored rather than not being able to take any action at all.

🛠 How

  • Added tests for non-live error states.
  • Removed some invalid tests that were testing non-backer error states which aren't possible 🤷‍♂
  • Updated all error tests to prove that they will display normal backing states for now.

👀 See

See new and updated snapshots attached to this PR.

Copy link
Contributor

@cdolm92 cdolm92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Do we want the exclamation icon and not the checkmark here?

Copy link
Contributor

@cdolm92 cdolm92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉!

@dusi dusi merged commit d1662c2 into master Aug 27, 2019
@dusi dusi deleted the add-error-state-non-live branch August 27, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants