[NT-164] Consume Rewards converted minimum from v1 #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Sep 10, 2019
| @@ -5,6 +5,7 @@ import Runes | |||
|
|
|||
| public struct Reward { | |||
| public let backersCount: Int? | |||
| public let convertedMinimum: Double | |||
There was a problem hiding this comment.
Is convertedMinimum guaranteed to always be returned? If no conversion is required (ie. project's currency is the same as the user's currency) is the convertedMinimum just the same as the minimum?
| @@ -24,6 +25,7 @@ extension Reward { | |||
|
|
|||
| public static let noReward = Reward( | |||
| backersCount: nil, | |||
| convertedMinimum: 0, | |||
There was a problem hiding this comment.
I know this is just a template, but I think a convertedMinimum would never be 0 🤔 Maybe make this 1 so it's more realistic?
There was a problem hiding this comment.
I set convertedMinimum to 0 so it matches the minimum. For this template, all properties are either nil or 0.
Scollaco
changed the title
ifbarrera
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
convertedMinimumreturned by the API.🤔 Why
🛠 How
convertedMinimumto our Reward model.✅ Acceptance criteria