[NT-15] Users may pledge with Apple Pay #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding CreateApplePayBackingMutation and Input, plus decimal currency formatter * Adding the mutation to ServiceType * Formatting * Fixing minFractionDigits on attributedCurrency formatter & adding tests * Formatting * Adding comments * Use optionals, and use Strings for the input ids * Expanding on comment about en locale * Readability
* Adding CreateApplePayBackingMutation and Input, plus decimal currency formatter * Adding the mutation to ServiceType * Formatting * Fixing minFractionDigits on attributedCurrency formatter & adding tests * Formatting * Adding comments * Setup for showing payment authorization view * Setting up stripe configuration * Configure Stripe SDK and hook up button * Display PKPaymentAuthorizationViewController * Presenting the PKPaymentAuthorizationViewController and calling stripe * Use a new output signal for the createApplePayBacking’s status * Hooking up the mutation and adding view model logic * Improved paymentAuthorizationDidAuthorizePayment input type for testing * Adding transition to thanks screen * Don’t send rewardId for no rewards * PledgeViewModelTests and PledgePaymentMethodsViewModelTests * Refactoring for easier testing and adding more tests * PKPaymentRequestHelpersTests * Test for cancelling apple pay sheet * Linting and formatting * Cleanup * Formatting * Small refactor of handling for stripe token & error, and moar tests * Formatting * Tests for createApplePayBackingInput * Formatting * Moving input creation to it’s own file with tests * Fix naming conflict
ifbarrera
force-pushed
the
native-apple-pay
branch
from
5dc4414
to
e2b41ef
Compare
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
The feature branch containing all of the work integrating Apple Pay into the new Pledge screen.
Note: all this code has already gone through review.
PRs included:
#832
#828