👩🔬 [Investment Day] - Sort feature flags alphabetically #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusi
changed the title
dusi
commented
Oct 4, 2019
| @@ -7,7 +7,7 @@ import ReactiveSwift | |||
| import XCTest | |||
|
|
|||
| final class FeatureFlagToolsViewModelTests: TestCase { | |||
| private let vm = FeatureFlagToolsViewModel() | |||
| private let vm: FeatureFlagToolsViewModelType = FeatureFlagToolsViewModel() | |||
There was a problem hiding this comment.
This is so that we don't have direct access to VM's properties but have to go through input/output
There was a problem hiding this comment.
Thanks for changing this! 👍🏾
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
As the title says.
🤔 Why
Dealing with feature flags it's often confusing the two feature flags change order (this is because we're not sorting the returned array form the JSON). This should fix that.
🛠 How
Sorting based on the
descriptionfield.👀 See
✅ Acceptance criteria