Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NT-329] Localizations - Pledge input Apple Pay alert #881

Merged
merged 7 commits into from
Oct 10, 2019
Merged

[NT-329] Localizations - Pledge input Apple Pay alert #881

merged 7 commits into from
Oct 10, 2019

Conversation

dusi
Copy link
Contributor

@dusi dusi commented Oct 8, 2019 •
edited by cdolm92
Loading

📲 What

Adds localizations for the alert title & message.

🤔 Why

Para que otros puedan entender

👀 See

Trello, screenshots, external resources?

🇺🇸 🇩🇪 🇪🇸 🇫🇷 🇯🇵
Screen Shot 2019-10-08 at 2 03 06 PM Screen Shot 2019-10-08 at 2 03 27 PM Screen Shot 2019-10-08 at 2 03 46 PM Screen Shot 2019-10-09 at 9 44 22 AM Screen Shot 2019-10-08 at 2 04 50 PM

♿️ Accessibility

  • VoiceOver reads strings in their respective language

✅ Acceptance criteria

  1. Change language
  2. Navigate to the new pledge screen (make sure Apple Pay button can be displayed)
  3. Change input amount bellow minimum (or to empty)
  4. Tap Apple Pay button -> this will display the alert
  • English shows translated title & message text
  • German shows translated title & message text
  • Spanish shows translated title & message text
  • French shows translated title & message text
  • Japanese shows translated title & message text

@dusi dusi added the blocked a PR that is blocked for external reasons label Oct 8, 2019
@dusi dusi added needs review and removed blocked a PR that is blocked for external reasons labels Oct 9, 2019
@dusi dusi requested a review from justinswart October 9, 2019 16:45
cdolm92
cdolm92 approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@cdolm92 cdolm92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buen trabajo!! 🎉 🎉 🎉

@dusi dusi merged commit 412e28c into master Oct 10, 2019
@dusi dusi deleted the l10n-pledge-amount-apple-pay-alert branch October 10, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdolm92 cdolm92 cdolm92 approved these changes

@justinswart justinswart Awaiting requested review from justinswart

Assignees

@cdolm92 cdolm92

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dusi @cdolm92