Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-206] Localizations - Rewards received #882

Merged
merged 4 commits into from
Oct 9, 2019
Merged

Conversation

dusi
Copy link
Contributor

@dusi dusi commented Oct 8, 2019

📲 What

Adds localizations for German, Spanish and Japanese.

🤔 Why

Previously these 3 translations were missing.

👀 See

🇺🇸 🇩🇪 🇪🇸 🇫🇷 🇯🇵
Screen Shot 2019-10-08 at 2 23 33 PM Screen Shot 2019-10-08 at 2 23 44 PM Screen Shot 2019-10-08 at 2 23 57 PM Screen Shot 2019-10-08 at 2 24 09 PM Screen Shot 2019-10-08 at 2 24 23 PM

♿️ Accessibility

  • VoiceOver reads strings (for both the label and switch's accessibility label) in their respective language

✅ Acceptance criteria

  1. Change language
  2. Navigate to manage pledge screen
  3. Make sure this is not No reward and its status is backing status is collected
  • English shows translated reward received text in the label
  • German shows translated reward received text in the label
  • Spanish shows translated reward received text in the label
  • French shows translated reward received text in the label
  • Japanese shows translated reward received text in the label

@dusi dusi changed the title [NT-] Localizations - Rewards received [NT-206] Localizations - Rewards received Oct 8, 2019
@dusi dusi merged commit d35d2f5 into master Oct 9, 2019
@dusi dusi deleted the l10n-reward-received branch October 9, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants