-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-228, NT-376] Cancel Pledge Error Handling #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just have a minor suggestion and found something unusual going on with the Japanese strings translations.
@@ -60,6 +60,7 @@ | |||
"Cancel" = "キャンセル"; | |||
"Cancel_pledge" = "プレッジを取り消す"; | |||
"Cancel_your_pledge" = "プレッジを取り消す"; | |||
"Cancellation_reason" = "Motivo de cancelación"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the Japanese strings in Spanish? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question...
|> UITextField.lens.accessibilityLabel %~ { _ in Strings.Cancellation_reason() } | ||
|> UITextField.lens.placeholder %~ { _ in Strings.Tell_us_why_optional() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of the lens and do |> \.accessibilityLabel %~ { _ in Strings.Cancellation_reason() }
and |> \.placeholder %~ { _ in Strings.Tell_us_why_optional() }
here?
Library/Strings.swift
Outdated
- **de**: "Grund der Annullierung" | ||
- **es**: "Motivo de cancelación" | ||
- **fr**: "Motif d'annulation" | ||
- **ja**: "Motivo de cancelación" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too. Something went wrong with the Japanese translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this it's G2G!! 🛳🛳🛳
📲 What
Adds error handling via the message banner for the cancel pledge flow. This PR also adds the missing accessibility label on the cancellation reason text field, and updates the disabled and highlighted colors on the "Yes, cancel it" button.
🤔 Why
To let users know when cancelling their pledge has failed.
🛠 How
MessageBannerPresenting
conformance toCancelPledgeViewController
cancelPledgeError
outputcancellationReasonTextField
.disabled
and.highlighted
colors on theredButtonStyle
👀 See
♿️ Accessibility
✅ Acceptance criteria