Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NT-395] Upgrade Stripe SDK #896

Merged
merged 3 commits into from
Oct 16, 2019
Merged

[NT-395] Upgrade Stripe SDK #896

merged 3 commits into from
Oct 16, 2019

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Oct 15, 2019 •
edited by justinswart
Loading

📲 What

Upgrades the Stripe SDK to v18.0.0 in preparation for SCA work.

🤔 Why

So we can take advantage of SCA features within the updated Stripe SDK.

🛠 How

  • Bumped the version on the Cartfile, then ran carthage update stripe-ios
  • tested that adding a new card is working
  • tested that backing with apple pay is working

✅ Acceptance criteria

  • Test that adding a new card is working on production
  • Test that backing a project using Apple Pay is working using the old Pledge screen flow, in production

justinswart
justinswart approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@ifbarrera ifbarrera merged commit be2137d into master Oct 16, 2019
@ifbarrera ifbarrera deleted the upgrade-stripe-sdk branch October 16, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees

@justinswart justinswart

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifbarrera @justinswart