[NT-449] Update pledge disclaimer #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update-pledge-disclaimer
…update-pledge-disclaimer
…update-pledge-disclaimer
…update-pledge-disclaimer
…update-pledge-disclaimer
…update-pledge-disclaimer
Scollaco
reviewed
Oct 29, 2019
| @@ -141,13 +141,15 @@ public class PledgeViewModel: PledgeViewModelType, PledgeViewModelInputs, Pledge | |||
| } | |||
| .skipNil() | |||
|
|
|||
| self.confirmationLabelAttributedText = Signal.merge( | |||
| let initialProjectAndProject = Signal.merge( | |||
There was a problem hiding this comment.
Here the initialProjectAndProject are the same project, but emitted in different times and this can end up becoming misleading. Maybe something like this would be better?
let projectAndPledgeTotal = Signal.merge(
project,
project.takeWhen(self.traitCollectionDidChangeSignal)
)
.combineLatest(with: pledgeTotal)
self.confirmationLabelAttributedText = projectAndPledgeTotal
.ksr_debounce(.milliseconds(10), on: AppEnvironment.current.scheduler)
.map(attributedConfirmationString(with:pledgeTotal:))
.skipNil()
There was a problem hiding this comment.
Oh, I forgot to change that naming 🤦🏾♀️ .Thanks for improving!
| ], | ||
| documentAttributes: nil | ||
| ) else { return nil } | ||
| if project.stats.currentCurrency == project.stats.currency { |
There was a problem hiding this comment.
To make this function a bit smaller, we could extract this to a new function that returns a String based on the currencies.
| ) | ||
| } | ||
|
|
||
| let attributedString: NSMutableAttributedString = NSMutableAttributedString.init(string: fullString) |
There was a problem hiding this comment.
For consistency, the syntax without .init would be preferred (NSMutableAttributedString(string: fullString))
| |> \.month .~ 11 | ||
| |> \.day .~ 1 | ||
| |> \.year .~ 2_019 | ||
| |> \.timeZone .~ TimeZone.init(secondsFromGMT: 0) |
There was a problem hiding this comment.
I know this code was already here, but could you get rid of the .inits here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
We are now showing a disclaimer when updating pledge in different currency.
🤔 Why
So that users understand that they are about to be charged in a foreign currency and foreign transaction fees may apply.
🛠 How
Checking to see if the user's currency matches the project's. If not we show the conversion label otherwise we don't.
👀 See
✅ Acceptance criteria