[NT-394] Fix loading button title restoration #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
commented
Oct 30, 2019
| @@ -115,7 +115,7 @@ final class LoadingButton: UIButton { | |||
| let states: [UIControl.State] = [.disabled, .highlighted, .normal, .selected] | |||
|
|
|||
| states.compactMap { state -> (String, UIControl.State)? in | |||
| guard let title = self.title(for: state) else { return nil } | |||
There was a problem hiding this comment.
The bug was just that this line was copy-pasted from the block above whereas it should in fact be restoring the title from the array and not self.title(for:).
dusi
approved these changes
Oct 30, 2019
Scollaco
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes a small bug which left our button title empty after the loader was hidden.
🤔 Why
This was just a small oversight in #892.
🛠 How
Fixed what was essentially just a copy-paste error.
👀 See
♿️ Accessibility
✅ Acceptance criteria