[NT-539] add background to reward section #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…background-to-reward-section
Scollaco
suggested changes
Nov 15, 2019
There was a problem hiding this comment.
I was taking a look at the code and actually we could make this work a bit simpler.
I opened this PR some time ago and what we can do is revert the changes (related to backgroundColor and styling) of RewardCardView and RewardCardViewModel and add a container UIViewon ManagePledgeRewardView with rounded corners and white background to place the reward view in it.
Doing this we will also avoid working with the complexity of the other RewardCardContainerView. I'm happy to pair on this if you want :)
…background-to-reward-section
Scollaco
reviewed
Nov 19, 2019
| _ = self.rewardView | ||
| |> checkoutBackgroundStyle | ||
| _ = self.backgroundView | ||
| |> checkoutWhiteBackgroundStyle |
There was a problem hiding this comment.
Here we can create a let backgroundViewStyle and move the styling to the bottom of the file.
| @@ -12,6 +12,7 @@ final class ManagePledgeRewardView: UIView { | |||
|
|
|||
| private lazy var rootStackView: UIStackView = { UIStackView(frame: .zero) }() | |||
| private lazy var titleLabel: UILabel = { UILabel(frame: .zero) }() | |||
| private lazy var backgroundView: UIView = { UIView(frame: .zero) }() | |||
There was a problem hiding this comment.
Can you alphabetize here? 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
The white background is shown behind the reward section of the View/Manage Pledge screen for both backers and creators.
🛠 How
Reused
rewardCardContainerViewinManagePledgeRewardView👀 See
Check out snapshots too!
✅ Acceptance criteria