[NT-526] Max pledge error handling polish #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdolm92
approved these changes
Nov 19, 2019
| @@ -158,11 +158,10 @@ public final class PledgeAmountViewModel: PledgeAmountViewModelType, | |||
| .map { ($0.0, $0.1) } | |||
There was a problem hiding this comment.
Should we just map to the max amount because we're not using the minimum amount anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
.right🤔 Why
JIRA ticket
🛠 How
textAlignmentof label to.right👀 See
♿️ Accessibility
✅ Acceptance criteria
maximumvalue. A label with the textThe maximum pledge is [currency] [maximum pledge amount].