Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt 545 transition from thanks page to project page #977

Merged
merged 5 commits into from
Dec 3, 2019

Conversation

Scollaco
Copy link
Contributor

@Scollaco Scollaco commented Dec 2, 2019

📲 What

  • Changes the way we present the Thanks page (modally instead of using a push animation).
  • Brings users back to the ProjectPage once they back a project.

🤔 Why

  • The transition changed because the animation was inconsistent, where the ViewController was being presented with a push animation but being dismissed with a modal animation.
  • To improve UX, user can now see right away the Project Page updated with the status of their backing.

JIRA ticket

🛠 How

  • By changing the implementation of the dismissToRootViewController from self?.view.window?.rootViewController?.dismiss(animated: true, completion: nil) to self?.dismiss(animated: true, completion: nil)

  • To push the ThanksVC with a modal animation, an UINavigationController extension was created. It contains a function pushViewControllerModally that imitates the animation of the present(viewController:animated:) function.

👀 See

Trello, screenshots, external resources?

Before 🐛 After 🦋
thanks-page-before thanks-to-project

✅ Acceptance criteria

  • Back a project and on the Thanks Page, tap the X button. The ThanksPage should be dismissed (with no animation) and you should be brought to the Project Page.
  • The CTA button of the ProjectPage should be updated according to the current status of the backing (e.g. Manage)

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Ship it when tests pass!

@Scollaco Scollaco merged commit 85d209e into master Dec 3, 2019
@Scollaco Scollaco deleted the NT-545-transition-from-thanks-page-to-project-page branch December 3, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants