-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-649] Errored pledges query #981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool lgtm, had minor comments!
KsApi/models/GraphBackingTests.swift
Outdated
} | ||
} | ||
""" | ||
let data = jsonString.data(using: .utf8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use the non-failable Data
initializer then we don't need to force-unwrap later on:
let data = Data(jsonString.utf8)
public var slug: String | ||
} | ||
|
||
public enum Status: String, CaseIterable, Swift.Decodable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the back-end also has a status authentication_required
🤔
📲 What
🤔 Why
ActivitiesViewController
and allow users to fix them.🛠 How
GraphBacking
ActivityViewModel
that emits the list of errored pledgesJIRA ticket
✅ Acceptance criteria
Testing with Charles
If there's no errored pledges
ActivitiesViewController
is open and change thestatus
of backings toerrored
. TheerroredBackings
output on ActivitiesViewModel should emit a list with the errored pledges.