Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-688] Project events & properties clean up #985

Merged
merged 14 commits into from
Dec 16, 2019

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Dec 10, 2019

📲 What

Cleans up our project events, properties and tests to align with new requirements.

🤔 Why

So that we're sending only what is needed for analytics purposes.

🛠 How

Lots of moving around and renaming things, deleting un-used props, and adding better test coverage.

♿️ Accessibility

N/A

🏎 Performance

N/A

✅ Acceptance criteria

  • Project Page Viewed event fires when the project page is viewed
  • Project Swiped event fires when the project page controller is swiped to the next or previous project

The following properties are part of the projectProperties group, and are sent with all Project events:

  • project_backers_count
  • project_category
  • project_country
  • project_creator_uid
  • project_currency
  • project_deadline // time interval
  • project_duration // in days
  • project_goal
  • project_hours_remaining // in hours
  • project_launched_at // time interval
  • project_location
  • project_name
  • project_parent_category
  • project_percent_raised
  • project_pid
  • project_pledged
  • project_has_video
  • project_current_pledge_amount_usd
  • project_goal_usd
  • project_state
  • project_static_usd_rate
  • project_user_has_watched
  • project_user_is_backer
  • project_user_is_project_creator
  • project_comments_count

⏰ TODO

  • determine whether adding project_tags is a blocker for this PR: we don't currently have access to project tags in our Project model
  • get clarification on whether project_is_repeat_creator is actually sending the desired value

@ifbarrera ifbarrera marked this pull request as ready for review December 11, 2019 18:11
@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Tested logged in and out, minor questions/comments.

Library/Tracking/Koala.swift Show resolved Hide resolved
KsApi/models/Project.swift Show resolved Hide resolved
Library/Tracking/Koala.swift Show resolved Hide resolved
Library/Tracking/Koala.swift Outdated Show resolved Hide resolved
Library/Tracking/Koala.swift Show resolved Hide resolved
@ifbarrera ifbarrera merged commit b6ca3ef into master Dec 16, 2019
@ifbarrera ifbarrera deleted the NT-688-project-events-clean branch December 16, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants