-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-688] Project events & properties clean up #985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NT-688-project-events-clean
Generated by 🚫 Danger |
justinswart
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tested logged in and out, minor questions/comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Cleans up our project events, properties and tests to align with new requirements.
🤔 Why
So that we're sending only what is needed for analytics purposes.
🛠 How
Lots of moving around and renaming things, deleting un-used props, and adding better test coverage.
♿️ Accessibility
N/A
🏎 Performance
N/A
✅ Acceptance criteria
Project Page Viewed
event fires when the project page is viewedProject Swiped
event fires when the project page controller is swiped to the next or previous projectThe following properties are part of the
projectProperties
group, and are sent with allProject
events:project_backers_count
project_category
project_country
project_creator_uid
project_currency
project_deadline
// time intervalproject_duration
// in daysproject_goal
project_hours_remaining
// in hoursproject_launched_at
// time intervalproject_location
project_name
project_parent_category
project_percent_raised
project_pid
project_pledged
project_has_video
project_current_pledge_amount_usd
project_goal_usd
project_state
project_static_usd_rate
project_user_has_watched
project_user_is_backer
project_user_is_project_creator
project_comments_count
⏰ TODO
project_tags
is a blocker for this PR: we don't currently have access to project tags in ourProject
modelproject_is_repeat_creator
is actually sending the desired value