[NT-645] Clean user properties & session properties

[ifbarrera]

#📲 What

Adds clean user properties and session properties, with tests.

🤔 Why

Part of the data cleanup project.

🛠 How

• cleans up defaultProperties and rename to sessionProperties
• adds userProperties to decouple user props from session props

Now, instead of having user properties in the defaultProperties function, we build them separately and join all properties together with:

let props = self.sessionProperties()
    .withAllValuesFrom(userProperties())
    .withAllValuesFrom(eventProperties)

Note that unfortunately, we're not in a good place to test some of the session properties that don't have mocks. I've made a note and filed a separate tech debt ticket to address this so we can be sure to test all session properties in the near future.

♿️ Accessibility

N/A

🏎 Performance

N/A

✅ Acceptance criteria

• Verify that all the tests in KoalaTests.swift are correct

Verify that the following session properties are sent on every tracking event:

• apple_pay_capable
• apple_pay_device
• cellular_connection
• client_type
• current_variants
• device
• device_fingerprint
• device_format
• device_manufacturer
• device_model
• device_orientation
• distinct_id
• enabled_features
• iphone_uuid
• is_voiceover_running
• mp_lib
• os
• os_version
• time
• app_version
• app_release // might re-name to app_build
• screen_width
• user_agent
• user_logged_in
• wifi_connection
• client_platform

Verify that the following user properties are sent on every tracking event:

• user_is_admin // only if logged in
• user_backed_projects_count // only if logged in
• user_country
• user_facebook_account // only if logged in
• user_watched_projects_count // only if logged in
• user_uid // only if logged in

⏰ TODO

• finalize exact native session props

[Scollaco]

Good job, @ifbarrera . I just have a question regarding a property name, but it looks good otherwise.

[justinswart]

Nice!

[justinswart]

As discussed on Slack this, device_fingerprint and iphone_uuid all appear to be the same value.

[ifbarrera]

I'll bring it up with insights and remove one property in a follow-up PR if they're ok with it.

[justinswart]

Not remove two props?

[ifbarrera]

Sorry yes. Consolidate to one prop.

[justinswart]

Best to keep the FIXME: here or track in a Jira ticket?

[ifbarrera]

It's in both, I can remove it from here if you think it's too noisy.