Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed benchmark tests #2

Merged
merged 1 commit into from
Oct 9, 2013
Merged

Fixed benchmark tests #2

merged 1 commit into from
Oct 9, 2013

Conversation

joonas
Copy link
Contributor

@joonas joonas commented Oct 9, 2013

No description provided.

@ktheory
Copy link
Contributor

ktheory commented Oct 9, 2013

That's awesome! ❤️ I wonder why MiniTest::Spec.bench_range works in my local env...

ktheory added a commit that referenced this pull request Oct 9, 2013
@ktheory
Merge pull request #2 from joonas/fix_benchmark_tests
7593df8 
Fixed benchmark tests
@ktheory ktheory merged commit 7593df8 into kickstarter:master Oct 9, 2013
@joonas
Copy link
Contributor Author

joonas commented Oct 9, 2013

I have no idea why that is, but I saw that the build badge was red and the benchmark test wasn't working for me locally, so I figured I'd try to fix it.

@joonas joonas deleted the fix_benchmark_tests branch October 9, 2013 19:45
@ktheory
Copy link
Contributor

ktheory commented Oct 9, 2013

Thanks for fixing. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonas @ktheory