Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot push calendar events with org-id #61

Closed
EdGrrr opened this issue Dec 15, 2019 · 3 comments · Fixed by #74
Closed

Cannot push calendar events with org-id #61

EdGrrr opened this issue Dec 15, 2019 · 3 comments · Fixed by #74
Labels
enhancement New feature or request

Comments

@EdGrrr
Copy link

EdGrrr commented Dec 15, 2019

If an entry already has an org-id, then it cannot be pushed to the google calendar. A 404 is returned instead. I think this is because org-gcal is trying to use the org-id to locate the event in google calendar.

With an example event;

* TestPersonal                                                  :CAL:                                    
  SCHEDULED: <2019-12-18 Wed 08:00-09:00>                                                                
  :PROPERTIES:                                                                                           
  :ID:       bf928034-9dac-463b-a038-a6f988480269                                                        
  :calendar-id: <my-calendar-id>@group.calendar.google.com                                  
  :END:

org-gcal-post-at-point returns 404. If the :ID: property is removed, then everything works as expected.

Could the gcal ID property be renamed (e.g. GID?). This might fix the issue.

@telotortium telotortium added the enhancement New feature or request label Dec 15, 2019
@telotortium
Copy link
Collaborator

I've known about this issue for a while. I think adding a new property for the calendar and event ID is probably the best solution. However, the reason I went with using the ID in the first place was to be able to use org-id-find to quickly navigate to an event to update it from org-gcal-sync. Ideally the logic from that function could either be reused as-is, or else I could make a copy of the logic but change the property name.

@EdGrrr
Copy link
Author

EdGrrr commented Dec 15, 2019

I was looking at this a bit over the last few hours. If I understand it correctly, having multiple IDs for a entry is fine, so the current setup should work.

Is this connected to #52? Presumably, if it was possible at one point to request the calendar-id, it would also be possible to determine the google-id for the event too? I have very little elisp experience, so I am not entirely sure what is possible here.

@telotortium
Copy link
Collaborator

telotortium commented Apr 13, 2020

@EdGrrr In #71 I added code to only use the existing ID property if it matches the format of the IDs generated by org-gcal, which won't match a UUID like you have there. Can you check if that works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants