-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple account support #5
Conversation
Hey! I've tested it myself and seems to work great :) Before merging it, I have a few questions though:
|
+1 thank you @telotortium for merging against @kidd ! |
Hi @kidd:
|
So I tried it and *-at-point do not work properly. I'll take this branch from here and try to fix it. For now it doesn't go into master yet :(. |
Yeah, it looks like there's no property containing the calendar ID of the calendar the event came from. One should probably be added. In the meantime, you can infer it from the gcal.org file where the event entry is found using |
FYI I have just posted a fix to a similar problem in the parent repository: it supports multiple calendars, albeit from a single account (and a single token). |
@gciolli, I think I like your fix better than having multiple tokens. also, multiple tokens made it slower as there's one token per calendar, not just per "owner". When I have some time I'll merge your branch in, and we'll close this one. Thanks everyone for your collaboration! |
I ended up merging #9 which solves the {delete,post}-at-point in a clean way. The multiple accounts is a non-issue as one can give calendar permissions to another account via google calendar interface. I think it keeps the code nicer and it's faster. Thanks all for bringing ideas and PRs. |
The myuhe version of org-gcal.el doesn't allow calendars from multiple Google accounts to be synced in the same instance of Emacs, since only a single Google Calendar token can be held. @ayyjayess and @sattisvar have created patches to org-gcal.el that add such support, by turning
org-gcal-token-plist
intoorg-gcal-tokens-plist
. I've been using this in my own repo for over half a year at this point and everything has worked seamlessly - I can sync my personal and work accounts into the same Emacs (in separategcal.org
files). I've merged these patches into the currentmaster
version of your repo, so they should be good to go.