Adding Support for MCP3208 (12 bit version of MCP3008) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the MCP3008 execpt for being 12 bits. Signed-off-by: npotts <npotts@users.noreply.github.com>
Signed-off-by: npotts <npotts@users.noreply.github.com>
…man#24) Signed-off-by: npotts <npotts@users.noreply.github.com>
Signed-off-by: npotts <npotts@users.noreply.github.com>
Add newly required 3rd argument
analogic
added a commit
to analogic/embd
that referenced
this pull request
May 27, 2017
Copy of mcp3008 with necessary changes derived from kidoman#47 to make MCP3208 work. Creating new driver instead of changing API of different model (like pull 47) seems to be better choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have hacked in support for a MCP3204/8 (12 bit version of MCP3004/8), and I am wondering if i should add it into the MCP3008 struct, or make a copy of the 3008 - Per the datasheets precious little else is different. On RPi2+, this also needs the patch from #24
I am open trying to generalize the current MCP3008 driver, but I just haven't researched the realm of other chip-sets that have a similar interface.