Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shipped act binary does not work on macOS #23

Closed
shubhbapna opened this issue Apr 11, 2023 · 0 comments · Fixed by #31
Closed

Shipped act binary does not work on macOS #23

shubhbapna opened this issue Apr 11, 2023 · 0 comments · Fixed by #31
Assignees
@bacciotti
Labels
bug Something isn't working

Comments

@shubhbapna
Copy link
Collaborator

Describe the bug
The error is:

Errors .../mock-github-act-js-examples/workflow/simple/node_modules/@kie/act-js/build/bin/act:
.../mock-github-act-js-examples/workflow/simple/node_modules/@kie/act-js/build/bin/act: cannot execute binary file

npx act-js prints the same error

It starts working when user sets ACT_BINARY to their local act installation. There seems to be an issue with the act binary built by this package

To Reproduce
Clone and run shubhbapna/mock-github-act-js-examples in the following environment:

Apple M1 Ventura 13.0
node: v16.15.0
git: 2.40.0

Expected behavior
The act binary shipped with this package should work on macOS as well

Additional context
Reported by @aleksei-commmune in shubhbapna/mock-github-act-js-examples#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bacciotti bacciotti

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dynamically download the right act binary based on user os and architecture shubhbapna/act-js
2 participants
@bacciotti @shubhbapna