-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dynamically download the right act
binary based on user os and architecture
#31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Windows test are failing because linux containers cannot be run in a windows runner: We could use For macos I suspect the 1 test that is failing might be because of the "hack" for setting up docker. I will open an issue to investigate this further but one alternative could be to rely on The CI tests are failing since matrix has not been implemented. Once #20 is implemented I will fix the CI tests |
Fixes #23
Using a post install hook, as soon as the user runs
npm i @kie/act-js
, the post install script will installact
as well by directly downloading the zipped releases from https://github.com/nektos/act/releases based on user's OS and architecture