Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamically download the right act binary based on user os and architecture #31

Merged
merged 14 commits into from
Apr 27, 2023

Conversation

shubhbapna
Copy link
Collaborator

Fixes #23

Using a post install hook, as soon as the user runs npm i @kie/act-js, the post install script will install act as well by directly downloading the zipped releases from https://github.com/nektos/act/releases based on user's OS and architecture

Copy link

@bacciotti bacciotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bacciotti bacciotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bacciotti bacciotti self-requested a review April 21, 2023 08:44
@shubhbapna
Copy link
Collaborator Author

Windows test are failing because linux containers cannot be run in a windows runner:

We could use -self-hosted platform to run it directly on windows without docker but some bash commands might not run.

For macos I suspect the 1 test that is failing might be because of the "hack" for setting up docker. I will open an issue to investigate this further but one alternative could be to rely on -self-hosted platform for the tests to run in CIs

The CI tests are failing since matrix has not been implemented. Once #20 is implemented I will fix the CI tests

@shubhbapna shubhbapna merged commit 1dc7340 into kiegroup:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shipped act binary does not work on macOS
2 participants