Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Act interface #2

Merged
merged 17 commits into from
Nov 23, 2022
Merged

Act interface #2

merged 17 commits into from
Nov 23, 2022

Conversation

shubhbapna
Copy link
Collaborator

@shubhbapna shubhbapna commented Nov 22, 2022 •
edited
Loading

Merge after:

Resolves #1

@shubhbapna shubhbapna marked this pull request as draft November 22, 2022 23:50
@shubhbapna shubhbapna added the Do not merge Do not merge PR until label is removed label Nov 22, 2022
Ginxo
Ginxo approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubhbapna shubhbapna marked this pull request as ready for review November 23, 2022 15:46
@shubhbapna shubhbapna removed the Do not merge Do not merge PR until label is removed label Nov 23, 2022
@shubhbapna shubhbapna merged commit 857333c into kiegroup:main Nov 23, 2022
@shubhbapna shubhbapna mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ginxo Ginxo Ginxo approved these changes

@lampajr lampajr Awaiting requested review from lampajr

@rgdoliveira rgdoliveira Awaiting requested review from rgdoliveira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract Act from mock-github
2 participants
@shubhbapna @Ginxo