Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow selective override of keys in inputs field in the workflow file when using setInput #64

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

im-sampm
Copy link
Contributor

@im-sampm im-sampm commented Jan 5, 2024

When triggering a workflow_dispatch event, the event payload must contain the inputs key.

However, this key is always overwritten as the code is currently written.

This change allows the simultaneous use of act.setInput() and passing an event payload containing an inputs key.

@shubhbapna shubhbapna self-requested a review January 9, 2024 07:51
Copy link
Collaborator

@shubhbapna shubhbapna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not sure why this didn't trigger all PR checks

@shubhbapna
Copy link
Collaborator

Tested this locally and doesn't seem to break anything. Moreover since the change is quite small, I think just by looking at it, it shouldn't break anything. I will go ahead and merge it.

@shubhbapna shubhbapna changed the title Fixed bug when inputs and event payload are used simultaneously fix: allow the use of setInput along with the inputs keyword in the workflow file Jan 12, 2024
@shubhbapna shubhbapna changed the title fix: allow the use of setInput along with the inputs keyword in the workflow file fix: allow selective override of keys in inputs field in the workflow file when using setInput Jan 12, 2024
@shubhbapna shubhbapna merged commit 83ce2b3 into kiegroup:main Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants