Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBPM-9542: Remove issue-keeper tool #1828

Merged
merged 2 commits into from
Jan 7, 2021
Merged

JBPM-9542: Remove issue-keeper tool #1828

merged 2 commits into from
Jan 7, 2021

Conversation

jomarko
Copy link

@jomarko jomarko commented Jan 6, 2021

Due to recent jira authentication changes we decided to stop using issue-keeper tool for preventing test method run. It was replaced by simple '@ignore' junit annotations.

For more details see:

Thank you for submitting this pull request

JIRA: https://issues.redhat.com/browse/JBPM-9542

referenced Pull Requests:

Due to recent jira authentication changes we decided to stop using issue-keeper tool for preventing test method run. It was replaced by simple '@ignore' junit annotations.

For more details see:
- https://issues.redhat.com/browse/JBPM-9542
- https://github.com/ibek/issue-keeper
@@ -82,7 +82,7 @@ public void testTaskErrorHandling() throws Exception {
}

@Test(timeout=10000)
@BZ("1121027")
@Ignore("1121027")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case of BZ do we want to use better description like full BZ URL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just prepend it with BZ, so it would be BZ-1121027.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be enough, even the better to include full URL as you still need to understand what BZ is and how to view it in your browser

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, the URL can change and having to maintain many links can be cumbersome :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used BZ-123456 format in the new commit. Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be changed certainly, but usually there is a redirect setup, as it is our jira/bz we can control that by asking to have such redirection in future too ;)

Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will double-check after the PR check is finished if the number of ignored tests is the same. Thanks for that!

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jomarko
Copy link
Author

jomarko commented Jan 6, 2021

@MarianMacik I hope number of tests is correct. Compared 1 with 2

@mareknovotny mareknovotny merged commit 704d821 into kiegroup:master Jan 7, 2021
mareknovotny pushed a commit that referenced this pull request Jan 8, 2021
* JBPM-9542: Remove issue-keeper tool

Due to recent jira authentication changes we decided to stop using issue-keeper tool for preventing test method run. It was replaced by simple '@ignore' junit annotations.

For more details see:
- https://issues.redhat.com/browse/JBPM-9542
- https://github.com/ibek/issue-keeper

* keep just non closed BZs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants