-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBPM-9542: Remove issue-keeper tool #1828
Conversation
Due to recent jira authentication changes we decided to stop using issue-keeper tool for preventing test method run. It was replaced by simple '@ignore' junit annotations. For more details see: - https://issues.redhat.com/browse/JBPM-9542 - https://github.com/ibek/issue-keeper
@@ -82,7 +82,7 @@ public void testTaskErrorHandling() throws Exception { | |||
} | |||
|
|||
@Test(timeout=10000) | |||
@BZ("1121027") | |||
@Ignore("1121027") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case of BZ do we want to use better description like full BZ URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just prepend it with BZ
, so it would be BZ-1121027
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could be enough, even the better to include full URL as you still need to understand what BZ is and how to view it in your browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, the URL can change and having to maintain many links can be cumbersome :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used BZ-123456 format in the new commit. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could be changed certainly, but usually there is a redirect setup, as it is our jira/bz we can control that by asking to have such redirection in future too ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I will double-check after the PR check is finished if the number of ignored tests is the same. Thanks for that!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@MarianMacik I hope number of tests is correct. Compared 1 with 2 |
* JBPM-9542: Remove issue-keeper tool Due to recent jira authentication changes we decided to stop using issue-keeper tool for preventing test method run. It was replaced by simple '@ignore' junit annotations. For more details see: - https://issues.redhat.com/browse/JBPM-9542 - https://github.com/ibek/issue-keeper * keep just non closed BZs
Due to recent jira authentication changes we decided to stop using issue-keeper tool for preventing test method run. It was replaced by simple '@ignore' junit annotations.
For more details see:
Thank you for submitting this pull request
JIRA: https://issues.redhat.com/browse/JBPM-9542
referenced Pull Requests: