KOGITO-3718: Importing DMN as Included Model in VS Code on Windows #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ederign
approved these changes
Jan 21, 2021
|
@danielzhe can you please help us test this? |
caponetto
approved these changes
Jan 21, 2021
danielzhe
approved these changes
Jan 21, 2021
tomasdavidorg
requested review from
jomarko
and removed request for
tomasdavidorg
jomarko
reviewed
Jan 22, 2021
|
@jomarko Thanks for the review! VS Code does not provide an easy way for us to unit-test it, so we would have to rely on heavy mocking to write them at the moment. We're researching what's the best way to approach unit tests for our VS Code Extension yet, but so far we don't have anything in place. This is something very important that will be addressed as soon as we have the resources to do so. |
jomarko
approved these changes
Jan 25, 2021
adrielparedes
pushed a commit
to adrielparedes/kogito-tooling
that referenced
this pull request
Jan 26, 2021
adrielparedes
pushed a commit
to adrielparedes/kogito-tooling
that referenced
this pull request
Jan 26, 2021
adrielparedes
pushed a commit
to adrielparedes/kogito-tooling
that referenced
this pull request
Jan 29, 2021
tiagobento
added a commit
that referenced
this pull request
Feb 8, 2021
* KOGITO-3846: Added notifications api to kogito tooling * KOGITO-3846: Upgrade version to 0.8.3 * Importing DMN as Included Model in VS Code on Windows (#391) * KOGITO-3846: Added notifications api to kogito tooling * Update Editors to 7.50.0-SNAPSHOT-20210203.151532 Co-authored-by: Jan Stastny <jstastny@redhat.com> Co-authored-by: Tiago Bento <1584568+tiagobento@users.noreply.github.com> Co-authored-by: Kogito Tooling Bot (kiegroup) <kietooling@gmail.com>
ricardozanini
pushed a commit
to ricardozanini/kogito-tooling
that referenced
this pull request
Nov 15, 2024
Prepare master branch for the next version iteration. See: https://issues.redhat.com/browse/KOGITO-1946 Signed-off-by: spolti <fspolti@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After analysing this issue more carefully, the issue was that, on Windows, the extension was not correctly identifying the current directory of the open file, and it was always falling back to the root of the Workspace.
A workaround for this issue is to always work on the root folder of the Workspace. Keep in mind that even after this fix, only DMNs on the same folder can be used as Included Models.