Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated WidgetProperties and simplify klighd.ui.printing.dialog #148

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Replace deprecated WidgetProperties and simplify klighd.ui.printing.dialog #148

merged 2 commits into from
Jan 9, 2023

Conversation

HannesWell
Copy link
Contributor

@HannesWell HannesWell commented Nov 17, 2022

This PR is split in two commits and has the goal to first simplify the classes in de.cau.cs.kieler.klighd.ui.printing.dialog and to replace the deprecated class org.eclipse.jface.databinding.swt.WidgetProperties, which is eventually removed in the Eclipse 2022-12 release.
The first commit addresses the first topic and the second one the second.

Please let me know if you prefer more fine grained PRs.

Edit: The deletion is done in eclipse-platform/eclipse.platform.ui@c44f8d7

Copy link
Member

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @HannesWell for this contribution and taking care about this "non-first-class-citizen feature" of KLighD.

In general I'm a bit hesitant on changes like in 'ActionBlock.java', which is basically just a white space change, but in the context of the changes in the other files it definitely makes sense.

In what kind of project are you using KLighD?
Can you drop us an example of the diagrams you're creating?

Best regards and thanks again!

@sailingKieler
Copy link
Member

I'll merge this together with #150.

@sailingKieler sailingKieler added the enhancement New feature or request label Jan 6, 2023
@sailingKieler sailingKieler reopened this Jan 6, 2023
@sailingKieler sailingKieler merged commit cf32626 into kieler:master Jan 9, 2023
@HannesWell
Copy link
Contributor Author

You're

In general I'm a bit hesitant on changes like in 'ActionBlock.java', which is basically just a white space change, but in the context of the changes in the other files it definitely makes sense.

Yes I understand that, but like you, in the context of the other changes I came to the same conclusion that it made sense to unify that.

In what kind of project are you using KLighD? Can you drop us an example of the diagrams you're creating?

It is a software aimed for (mechanical, aerospace, ...) engineers to design complex systems and helps to automate the design of such systems.

Some screenshots are below. Unfortunately this is closed source so I cannot share that with you.
This required some adjustments in the code. A colleague of mine did that and therefore I don't have an exact overview of what and how much changed, nevertheless I would like to contribute those changes upstream in this repo. Would you, in general, welcome more contributions?

@HannesWell HannesWell deleted the cleanUpPrinting branch January 15, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants