lsp: switched to lazy tracing of diagram elements. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the element trace on SModelElements is required for tracing from text to the diagram or vice versa the traces are now generated lazily only when they are needed. This speeds up the initial diagram generation time, especially for very large graphs, where the PositionConverter#toPosition has an O(n^2) runtime in the model size because it runs through every character of the model for every model element. Tracing from diagram to text is now fast, text to diagram still goes through the all traces and suffers from above mentioned bad runtime for very large graphs. Closes #57. Closes #90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the element trace on SModelElements is required for tracing from text
to the diagram or vice versa the traces are now generated lazily only
when they are needed. This speeds up the initial diagram generation
time, especially for very large graphs, where the
PositionConverter#toPosition has an O(n^2) runtime in the model size
because it runs through every character of the model for every model
element.
Tracing from diagram to text is now fast, text to diagram still goes
through the all traces and suffers from above mentioned bad runtime for
very large graphs.
Closes #57.
Closes #90.